Detect quoted pattern variables in alternatives #15073
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
smarter
reviewed
Apr 30, 2022
| case Typed(pat, _) => rec(pat) | ||
| case UnApply(_, _, pats) => pats.foreach(rec) | ||
| case pat: Bind => | ||
| report.error(IllegalVariableInPatternAlternative(pat.symbol.name), pat.withSpan(pat.nameSpan)) |
Member
There was a problem hiding this comment.
How come we need to check this here, isn't typedBind going to run on this tree later and produce the same error via https://github.com/lampepfl/dotty/blob/400427db21410b366e4d9b890d73cec15416b632/compiler/src/dotty/tools/dotc/typer/Typer.scala#L2141-L2142 ?
Contributor
Author
There was a problem hiding this comment.
The context at that point lost the mode InPatternAlternative. Now I found out where that is happening and will push a better fix.
We use typedExpr to type the contents of a quoted pattern. In that case it must not have the Pattern mode mut should keep the InPatternAlternative because it will be needed in the pattern located in the splices.
smarter
approved these changes
May 5, 2022
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #14696